Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dstorage, dxsdk-d3dx, xaudio2redist] ports updated to support static-md triplets #24104

Merged
merged 3 commits into from
Apr 13, 2022
Merged

[dstorage, dxsdk-d3dx, xaudio2redist] ports updated to support static-md triplets #24104

merged 3 commits into from
Apr 13, 2022

Conversation

walbourn
Copy link
Member

@walbourn walbourn commented Apr 12, 2022 •
edited
Loading

Per feedback in 24063, I've updated the vcpkg.json supports statement to change the expression !static to !(static & staticcrt).

Since these ports use vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY), they will fallback to using dynamic library automatically for the windows-static-md triplets, but they don't support windows-static.

@walbourn
Copy link
Member Author

walbourn commented Apr 12, 2022 •
edited
Loading

Validated the following triplets:

vcpkg install dstorage:x64-windows
vcpkg install dstorage:x86-windows
vcpkg install dstorage:x64-windows-static-md
vcpkg install dstorage:x86-windows-static-md

vcpkg install dxsdk-d3dx:x64-windows
vcpkg install dxsdk-d3dx:x86-windows
vcpkg install dxsdk-d3dx:x64-windows-static-md
vcpkg install dxsdk-d3dx:x86-windows-static-md

vcpkg install xaudio2redist:x64-windows
vcpkg install xaudio2redist:x86-windows
vcpkg install xaudio2redist:x64-windows-static-md
vcpkg install xaudio2redist:x86-windows-static-md

vcpkg install directxtk[xaudio2redist]:x64-windows --recurse
vcpkg install directxtk[xaudio2redist]:x86-windows --recurse
vcpkg install directxtk[xaudio2redist]:x64-windows-static-md --recurse
vcpkg install directxtk[xaudio2redist]:x86-windows-static-md --recurse

Also confirmed directxmath, directxtk, directxtk12, directxtex, directxmesh, and uvatlas all support these triplets:

arm64-windows-static-md
x64-windows-static-md
x86-windows-static-md

@walbourn walbourn mentioned this pull request Apr 12, 2022
Merged
@FrankXie05 FrankXie05 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 13, 2022
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Apr 13, 2022
strega-nil-ms
strega-nil-ms suggested changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe these support a static CRT during a dynamic build either; there's no reason to mention static here (I believe Robert was incorrect in the original PR comments)

ports/dstorage/vcpkg.json Outdated Show resolved Hide resolved
@strega-nil-ms
Copy link
Contributor

Thanks!

@strega-nil-ms strega-nil-ms merged commit feef13c into microsoft:master Apr 13, 2022
@walbourn walbourn deleted the staticmdportupdates branch April 13, 2022 19:01
@walbourn walbourn mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@FrankXie05 FrankXie05 FrankXie05 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@walbourn @strega-nil-ms @FrankXie05 @strega-nil